Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Apache Iceberg quickstart page to the Beam website, significantly enhancing the documentation for data lake integration. It provides practical, multi-language code examples for common Iceberg operations, from catalog setup to data manipulation, ensuring users can quickly get started with Iceberg I/O in Beam. Additionally, the changes include necessary updates to the website's interactive components to better display and organize these new code snippets and structured content. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Hi, is the PR ready for review (saw check failures, in case it is in draft)? |
|
@Abacn I'll take care of the failures, but yes it's ready for review! |
|
Reminder, please take a look at this pr: @jrmccluskey @Abacn @shunping |
examples/java/build.gradle
Outdated
| implementation project(":sdks:java:io:google-cloud-platform") | ||
| implementation project(":sdks:java:io:kafka") | ||
| implementation project(":sdks:java:extensions:ml") | ||
| implementation project(":sdks:java:managed") |
There was a problem hiding this comment.
We should keep iceberg examples in examples/java/iceberg. There is an incoming risk Iceberg needs to be handled separately again as newer versions do not support Java11
There was a problem hiding this comment.
good catch, just moved them to examples/java/iceberg
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergScanConfig.java
Outdated
Show resolved
Hide resolved
| <ul class="section-nav-list"> | ||
| <li><a href="/documentation/io/built-in/parquet/">Apache Parquet I/O connector</a></li> | ||
| <li><a href="/documentation/io/built-in/hadoop/">Hadoop Input/Output Format IO</a></li> | ||
| <li><a href="/documentation/io/built-in/iceberg/">Apache Iceberg</a></li> |
There was a problem hiding this comment.
How are them ordered? Should we use alphabetical order or TOP IOs first + alphabetical order in remaining
There was a problem hiding this comment.
Just wanted to put Iceberg up top for visibility. I left everything else in the same order
There was a problem hiding this comment.
It largely seems to be in alphabetical order (with exception of CDAP being down there)
| @@ -0,0 +1,433 @@ | |||
| --- | |||
| title: "Apache Iceberg" | |||
There was a problem hiding this comment.
Changed to Apache Iceberg I/O connector
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
|
Abacn
left a comment
There was a problem hiding this comment.
Thanks!
May need to rerun a bunch of tests before merge to get a clean signal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37739 +/- ##
=============================================
+ Coverage 40.08% 56.90% +16.81%
Complexity 3416 3416
=============================================
Files 1177 1178 +1
Lines 187315 187561 +246
Branches 3588 3588
=============================================
+ Hits 75090 106725 +31635
+ Misses 108833 77446 -31387
+ Partials 3392 3390 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
http://apache-beam-website-pull-requests.storage.googleapis.com/37739/documentation/io/built-in/iceberg/index.html
Adding an Iceberg quickstart page to the Beam website
Includes examples for Hadoop Catalog (easy local development) and BigLake (cloud-scale development)
Includes the following SDKs: